Hi Hans

Thanks, I missed the redundant log entry.

I thought the same with regards to the commit message, after sending the 
review request :)

Please change and push for me.

Thanks
Gary

On 25/03/14 17:05, Hans Feldt wrote:
> Hi,
>
> Nack because we get redundant system stream entries with this change.
> I think the log in the same function that you changed should be
> removed. Logging will be done from avd_gen_su_ha_state_changed_ntf
>
> The commit message is a bit long, why not just "amfd: send
> notification when SI first assigned to SU [544]"
>
> I can do these changes before push if you are OK with them?
> Praveen?
>
> Thanks,
> Hans
>
>
> On 28 February 2014 05:19, Gary Lee <[email protected]> wrote:
>>   osaf/services/saf/amf/amfd/siass.cc |  1 +
>>   1 files changed, 1 insertions(+), 0 deletions(-)
>>
>>
>> diff --git a/osaf/services/saf/amf/amfd/siass.cc 
>> b/osaf/services/saf/amf/amfd/siass.cc
>> --- a/osaf/services/saf/amf/amfd/siass.cc
>> +++ b/osaf/services/saf/amf/amfd/siass.cc
>> @@ -259,6 +259,7 @@
>>                             avd_ha_state[state], su->name.value, 
>> si->name.value);
>>
>>                  avd_susi_update_assignment_counters(su_si, 
>> AVSV_SUSI_ACT_ASGN, state, state);
>> +               avd_gen_su_ha_state_changed_ntf(cb, su_si);
>>          }
>>
>>          TRACE_LEAVE();
>>
>> ------------------------------------------------------------------------------
>> Flow-based real-time traffic analytics software. Cisco certified tool.
>> Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer
>> Customize your own dashboards, set traffic alerts and generate reports.
>> Network behavioral analysis & security monitoring. All-in-one tool.
>> http://pubads.g.doubleclick.net/gampad/clk?id=126839071&iu=/4140/ostg.clktrk
>> _______________________________________________
>> Opensaf-devel mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/opensaf-devel


------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/13534_NeoTech
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to