Summary: amfd: assign only one csi per component for NPI SU [#856]
Review request for Trac Ticket(s): <<IF ANY LIST THE #>>
Peer Reviewer(s): Hans F., Nagendra
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es):All
Development branch: <<IF ANY GIVE THE REPO URL>>
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services y
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
Please see the commit log below.
changeset fbdb6d6fad3abe91eb9046bf40114b8826055c90
Author: praveen.malv...@oracle.com
Date: Tue, 15 Apr 2014 16:15:25 +0530
amfd: assign only one csi per component for NPI SU [#856]
Problem: Unlock of NPI SU hangs, if more than one CSIs are configured
for
one component.
Reason: AMFD created compcsi object for all the CSIs which can go to the
single component. When AMFND gets the assignment message from AMFD, it
assigns one CSI to the component. Since other CSIs remain unassigned,
AMFND
never responds to AMFD. This is the reason of hanging of unlock
operation.
Fix: While creating comp-csi objects, AMFD should not assign more than
one
CSis to a single component for NPI SU.
Complete diffstat:
------------------
osaf/services/saf/amf/amfd/sgproc.cc | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
Testing Commands:
-----------------
Tested as per ticket description.
Testing, Expected Results:
--------------------------
Pass.
Conditions of Submission:
-------------------------
Ack from Hans or Nagendra.
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 y y
x86_64 n n
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/NeoTech
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
