If we don't add validation now it can never be added. So is this an invalid configuration or not? /Hans
On 04/15/2014 02:43 PM, Hans Feldt wrote: > Potentially we could stop it by validation instead, but I am not sure. Could > break some (already broken) app configuration. > /Hans > >> -----Original Message----- >> From: praveen malviya [mailto:[email protected]] >> Sent: den 15 april 2014 13:14 >> To: Hans Feldt >> Cc: [email protected]; [email protected] >> Subject: Re: [PATCH 1 of 1] amfd: assign only one csi per component for NPI >> SU [#856] >> >> >> On 15-Apr-14 4:25 PM, Hans Feldt wrote: >>> Is it allowed to create more than one CSI for a non-sa-aware component? >> Spec does not say at CSI level for NPI component , but for SI assignment >> in NPI SU it is clearly mentioned in section 3.6.1.1 page 113 in B0401: >> " there is one and only one SI assignment per in-service service unit;" >> >> Referring to this "one csi per comp for NPI component" looks ok at CSI >> level. >> >> Thanks, >> Praveen >>> /Hans >>> >>>> -----Original Message----- >>>> From: [email protected] [mailto:[email protected]] >>>> Sent: den 15 april 2014 12:49 >>>> To: Hans Feldt; [email protected] >>>> Cc: [email protected] >>>> Subject: [PATCH 1 of 1] amfd: assign only one csi per component for NPI SU >>>> [#856] >>>> >>>> osaf/services/saf/amf/amfd/sgproc.cc | 6 +++++- >>>> 1 files changed, 5 insertions(+), 1 deletions(-) >>>> >>>> >>>> Problem: Unlock of NPI SU hangs, if more than one CSIs are configured >>>> for one component. >>>> >>>> Reason: AMFD created compcsi object for all the CSIs which can go to >>>> the single component. When AMFND gets the assignment message from AMFD, >>>> it assigns one CSI to the component. Since other CSIs remain unassigned, >>>> AMFND never responds to AMFD. This is the reason of hanging of unlock >>>> operation. >>>> >>>> Fix: While creating comp-csi objects, AMFD should not assign more than >>>> one CSis to a single component for NPI SU. >>>> >>>> diff --git a/osaf/services/saf/amf/amfd/sgproc.cc >>>> b/osaf/services/saf/amf/amfd/sgproc.cc >>>> --- a/osaf/services/saf/amf/amfd/sgproc.cc >>>> +++ b/osaf/services/saf/amf/amfd/sgproc.cc >>>> @@ -129,6 +129,10 @@ uint32_t avd_new_assgn_susi(AVD_CL_CB *c >>>> l_csi = l_csi->si_list_of_csi_next; >>>> } /* while(l_csi != AVD_CSI_NULL) */ >>>> >>>> + /* For NPI SU each component will get only one CSI and that is already >>>> assigned above.*/ >>>> + if (su->saAmfSUPreInstantiable == false) >>>> + goto npisu_done; >>>> + >>>> /* After previous while loop(while (l_csi != NULL)) all the >>>> deserving components got assigned at least one. Some >>>> components and csis may be left out. We need to ignore now >>>> all unassigned comps as they cann't be assigned >>>> any csi. Unassigned csis may include those csi, which cann't >>>> be assigned to any comp and those csi, which >>>> @@ -176,7 +180,7 @@ uint32_t avd_new_assgn_susi(AVD_CL_CB *c >>>> }/* if (false == l_csi->assign_flag)*/ >>>> l_csi = l_csi->si_list_of_csi_next; >>>> }/* while (l_csi != NULL) */ >>>> - >>>> +npisu_done: >>>> /* Log the unassigned csi.*/ >>>> l_csi = si->list_of_csi; >>>> while ((l_csi != NULL) && (false == l_csi->assign_flag)) { > > > ------------------------------------------------------------------------------ > Learn Graph Databases - Download FREE O'Reilly Book > "Graph Databases" is the definitive new guide to graph databases and their > applications. Written by three acclaimed leaders in the field, > this first edition is now available. Download your free book today! > http://p.sf.net/sfu/NeoTech > _______________________________________________ > Opensaf-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/opensaf-devel > > ------------------------------------------------------------------------------ Start Your Social Network Today - Download eXo Platform Build your Enterprise Intranet with eXo Platform Software Java Based Open Source Intranet - Social, Extensible, Cloud Ready Get Started Now And Turn Your Intranet Into A Collaboration Platform http://p.sf.net/sfu/ExoPlatform _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
