Ack. Have checked and tested and cannot see any problems Thanks Lennart
> -----Original Message----- > From: mathi.naic...@oracle.com [mailto:mathi.naic...@oracle.com] > Sent: den 18 april 2014 21:53 > To: Lennart Lund > Cc: opensaf-devel@lists.sourceforge.net > Subject: [PATCH 1 of 1] log: allow zero sized log records for app streams > [#857] > > osaf/libs/agents/saf/lga/lga_api.c | 5 ----- > 1 files changed, 0 insertions(+), 5 deletions(-) > > > There is a check in LGA as below: > if (logFileCreateAttributes->maxLogRecordSize == 0) { > TRACE(maxLogRecordSize); > return SA_AIS_ERR_INVALID_PARAM; > } > This prevents applications from opening a stream with zero sized records. > streamOpen() returns with error SA_AIS_ERR_INVALID_PARAM. > Without this patch, $ saflogger -a dummy > returns SA_AIS_ERR_INVALID_PARAM. > With this patch, $ saflogger -a dummy > works fine. > > diff --git a/osaf/libs/agents/saf/lga/lga_api.c > b/osaf/libs/agents/saf/lga/lga_api.c > --- a/osaf/libs/agents/saf/lga/lga_api.c > +++ b/osaf/libs/agents/saf/lga/lga_api.c > @@ -507,11 +507,6 @@ static SaAisErrorT validate_open_params( > return SA_AIS_ERR_INVALID_PARAM; > } > > - if (logFileCreateAttributes->maxLogRecordSize == 0) > { > - TRACE("maxLogRecordSize"); > - return SA_AIS_ERR_INVALID_PARAM; > - } > - > if (logFileCreateAttributes->logFileFullAction < > SA_LOG_FILE_FULL_ACTION_WRAP > || logFileCreateAttributes->logFileFullAction > > SA_LOG_FILE_FULL_ACTION_ROTATE) { > TRACE("logFileFullAction"); ------------------------------------------------------------------------------ Start Your Social Network Today - Download eXo Platform Build your Enterprise Intranet with eXo Platform Software Java Based Open Source Intranet - Social, Extensible, Cloud Ready Get Started Now And Turn Your Intranet Into A Collaboration Platform http://p.sf.net/sfu/ExoPlatform _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
