Ack from me on these patches.
I tested earlier with the prototype you sent out.
That was a slightly different (less mature) version of the tunneling patches,
but same prionciple.
Everything seems to work as expected.
All immomtest and immoitest pass except one as expected:
------------------------
# immoitest 3 6
Suite 3: Runtime Objects Management
6 FAILED saImmOiRtObjectCreate_2 - SA_AIS_ERR_NAME_TOO_LONG - size of dn
for new object too big (expected SA_AIS_ERR_NAME_TOO_LONG, got SA_AIS_OK)
=====================================================================================
Test Result:
Total: 1
Passed: 0
Failed: 1
------------------------
The pushing of only these patches will not impact any service in OpenSAF until
that
service chooses to implement support for long DNs over existing APIs using
these library functions.
Even though the IMM service has not yet implemented support for this, the
imm-om library is impacted
in the sense that these new functions have been placed in that library for
reasons of convenience.
I think therefore you should also increment OMLIB_VERSION in
osaf/libs/saf/libSaImm/Makefile.am to:
OMLIB_VERSION = 0:5:0
One issue remains unresolved that I know of.
IF a service/library has been built to support long DNs, but a client
initializes with the
library in the way that indicates that the client does not support long DNs,
then what should
the library do in the cases where a long DN appears from below in the library.
For callbacks I guess the natural approach would be to not generate the
callback to the client from
the library. But for cases where the callback expects a reply, some error code
should be sent by the library
back to the server. I would suggest ERR_BAD_OPERATION and preferrably an error
string added when possible.
For replies on requests, such as an saImmOmSearchNext where the object has a
long DN but the client
can not cope with it, there exists no appropriate existing alternative.
ERR_INVALID_PARAM has been
suggested. But that would be wrong since that error has the meaning of
interface-vialoation by the user.
That is not the case here. The only suitable alternatives I see are either
ERR_NAME_TOO_LONG or
ERR_BAD_HANDLE. The former is the naturally correct return code and could allow
the iteration to continue,
meaning only that an object was skipped in the search. BAD_HANDLE would be more
appropriate if the search
Has been terminated due to this error. The problem with BAD_HandLE is that it
overlaps the existing case
of the handle actually having being closed by the user or the service.
These issues do not have to be decided in order to push these patches for
supporting long-dn tunneling
through SaNameT. But we do need to decide before the first service implements
support for long DNs
using these new library funxitons. The IMM would naturally be the first
service. Closely followed
by NTF and LOG.
/AndersBj
-----Original Message-----
From: Anders Widell
Sent: den 2 maj 2014 12:51
To: mathi.naic...@oracle.com; Anders Björnerstedt
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 0 of 3] Review Request for Extended Name Type [#191]
Summary: Extended Name Type [#191]
Review request for Trac Ticket(s): 191
Peer Reviewer(s): Mathi, AndersBj
Pull request to:
Affected branch(es): default(4.5)
Development branch: default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs y
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries y
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
These patches add new AIS API functions and definitions for the extended
SaNameT format, used to tunnel NUL-terminated strings through SaNameT.
They also add support library functions to be used in agent libraries.
changeset f3cf7ffb53b9a4dd6026cf58c262a46eac8bca3a
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Fri, 02 May 2014 12:44:08 +0200
osaf: Add saAisNameLend() and saAisNameBorrow() [#191]
Add declarations of saAisNameLend() and saAisNameBorrow() to saAis.h.
Update
00-README.conf with description of how to enable the extended SaNameT
type.
changeset 84def835e0192244ba98eb6c80f192d2db26cd7d
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Fri, 02 May 2014 12:44:12 +0200
osaf: Add library functions for handling the extended SaNameT format
[#191]
These library functions are primarily intended to be used in agent
libraries, to handle the old SAF APIs that still are using the SaNameT
type.
changeset 99143446a43030c140d0ae95192546108b7639e2
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Fri, 02 May 2014 12:44:16 +0200
imm: Add implementations of saAisNameLend and saAisNameBorrow [#191]
The functions saAisNameLend() and saAisNameBorrow() are defined in
saAis_B_5_14.h, but their implementation is placed in libSaImmOm since
there
is no libSaAis library.
Complete diffstat:
------------------
00-README.conf | 18 +++++++++
osaf/libs/agents/saf/imma/Makefile.am | 1 +
osaf/libs/agents/saf/imma/aisa_api.c | 131
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
osaf/libs/core/common/Makefile.am | 1 +
osaf/libs/core/common/include/osaf_extended_name.h | 232
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
osaf/libs/core/common/osaf_extended_name.c | 184
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
osaf/libs/core/leap/sysf_def.c | 3 +
osaf/libs/saf/include/saAis.h | 4 ++
osaf/libs/saf/include/saAis_B_5_14.h | 17 ++++++++
osaf/libs/saf/libSaImm/libSaImmOm.map | 2 +
10 files changed, 593 insertions(+), 0 deletions(-)
Testing Commands:
-----------------
Build and start OpenSAF.
Testing, Expected Results:
--------------------------
OpenSAF should build and start successfully.
Conditions of Submission:
-------------------------
Ack from reviewers.
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Is your legacy SCM system holding you back? Join Perforce May 7 to find out:
• 3 signs your SCM is hindering your productivity
• Requirements for releasing software faster
• Expert tips and advice for migrating your SCM now
http://p.sf.net/sfu/perforce
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
