Summary: remove some use of EDU
Review request for Trac Ticket(s): 713
Peer Reviewer(s): AMF devels
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): <<LIST ALL AFFECTED BRANCH(ES)>>
Development branch: <<IF ANY GIVE THE REPO URL>>
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
As a preparation for making SG a class and to be able to subclass it into
redundancy model specific classes these changes are needed. As a side effect a
lot code lines are removed...
changeset c3146130bb6b74c93aeb4bdf9494440c1fedd317
Author: Hans Feldt <hans.fe...@ericsson.com>
Date: Wed, 28 May 2014 14:10:20 +0200
amfd: use simple decode in SU ckpt [713]
changeset a6f671cf8cde40255df3d20d7e3828a2ec5e8f75
Author: Hans Feldt <hans.fe...@ericsson.com>
Date: Wed, 28 May 2014 14:13:51 +0200
amfd: use simple encode in SU ckpt [713]
changeset 7ea868218f314b3527370e43252dd5423c2c6aa3
Author: Hans Feldt <hans.fe...@ericsson.com>
Date: Wed, 28 May 2014 14:14:06 +0200
amfd: remove SU EDU for ckpt [713]
changeset 20ed3e4bb316906b2c58e1970705a2786ea14aab
Author: Hans Feldt <hans.fe...@ericsson.com>
Date: Wed, 28 May 2014 14:34:33 +0200
amfd: use simple decode in SG ckpt [713]
changeset 893a13fab413aa5e9316e0f0a0f6cfc00123d8cb
Author: Hans Feldt <hans.fe...@ericsson.com>
Date: Wed, 28 May 2014 14:34:37 +0200
amfd: use simple encode in SG ckpt [713]
Complete diffstat:
------------------
osaf/services/saf/amf/amfd/ckpt_dec.cc | 738
+++++++++++++++++++++++++++++++++++++-------------------------------------------------------------------------------------------------
osaf/services/saf/amf/amfd/ckpt_edu.cc | 127 -----------------------
osaf/services/saf/amf/amfd/ckpt_enc.cc | 436
+++++++++++++++++++++++++-----------------------------------------------------
osaf/services/saf/amf/amfd/ckpt_updt.cc | 12 +-
osaf/services/saf/amf/amfd/include/ckpt_edu.h | 12 --
osaf/services/saf/amf/amfd/include/ckpt_updt.h | 2 +-
osaf/services/saf/amf/amfd/include/su.h | 2 +-
7 files changed, 355 insertions(+), 974 deletions(-)
Testing Commands:
-----------------
Build and start cluster, watch trace from standby amfd
Testing, Expected Results:
--------------------------
cluster comes up, new nice meaningful traces from syncing:
May 28 14:34:59.422358 osafamfd [466:ckpt_dec.cc:1437] << dec_su_pres_state:
'safSu=PL-3,safSg=NoRed,safApp=OpenSAF', saAmfSUPresenceState=1, su_updt:51
May 28 14:34:59.422450 osafamfd [466:ckpt_dec.cc:1396] >>
dec_su_readiness_state
May 28 14:34:59.422902 osafamfd [466:ckpt_dec.cc:1406] <<
dec_su_readiness_state: 'safSu=PL-3,safSg=NoRed,safApp=OpenSAF',
saAmfSuReadinessState=1, su_updt:52
Conditions of Submission:
-------------------------
<<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>>
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 n n
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Time is money. Stop wasting it! Get your web API in 5 minutes.
www.restlet.com/download
http://p.sf.net/sfu/restlet
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
