Summary: cpsv : fix CPA & CPND memleak [#1373] Review request for Trac Ticket(s): #1373 Peer Reviewer(s): Ramesh Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): 4.5 4.6 & default Development branch: default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services y Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset 41a382748df97f404b9a26acfdfc3f09d818766f Author: A V Mahesh <[email protected]> Date: Fri, 15 May 2015 13:11:31 +0530 cpsv : fix CPA & CPND memleak [#1373] 1) if ckpt application registered for saCkptCheckpointTrackCallback the cpnd_proc_ckpt_arrival_info_ntfy() will be triggered for that cpa from cpnd, as if ckpt_data->data & ckpt_data->readSize are not relevant to CPA, so readSize was assigned to zero and data is set to NULL , as an impact the ckpt_data->data was not visible in cpnd_evt_destroy() function which frees the memory ,the ckpt_data->data memory not visible and not freed, that is causing memory leak. As the readSize = Zero good enough data for cap to determine their no data, so NULL assignment to ckpt_data->data is removed. 2) If CPA accidentally/intentionally passes a negative value , as an impact the section leap times expiration time is being configured with huge value and timers are NOT being kept in free pool even after sorceress deleted, so application RSS memory continuously getting increased and being interpreted as memleak. No protection is added for timer start , but this will not prevent checkpoint/section creation the timer being configured as SA_TIME_END. Complete diffstat: ------------------ osaf/services/saf/cpsv/cpnd/cpnd_proc.c | 1 - osaf/services/saf/cpsv/cpnd/cpnd_tmr.c | 5 +++++ 2 files changed, 5 insertions(+), 1 deletions(-) Testing Commands: ----------------- run cap application with saCkptCheckpointTrackCallback see memory leak Testing, Expected Results: -------------------------- no memory leak Conditions of Submission: ------------------------- <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>> Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ One dashboard for servers and applications across Physical-Virtual-Cloud Widest out-of-the-box monitoring support with 50+ applications Performance metrics, stats and reports that give you Actionable Insights Deep dive visibility with transaction tracing using APM Insight. http://ad.doubleclick.net/ddm/clk/290420510;117567292;y _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
