Summary: IMM: Internal abort of active but idle CCB can cause invalid OM-handle
[#1412]
Review request for Trac Ticket(s): 1412
Peer Reviewer(s): Neel
Pull request to:
Affected branch(es): 4.5; 4.6; default(4.7)
Development branch: 4.7
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset b063db9e91b864153e4fef54140d674fc27cc245
Author: Anders Bjornerstedt <anders.bjornerst...@ericsson.com>
Date: Fri, 10 Jul 2015 15:53:15 +0200
IMM: Internal abort of active but idle CCB can cause invalid OM-handle
[#1412]
Correction done to ImmModel::ccbApply for correctly handling an attempt
to
apply a CCB that is already aborted.
Complete diffstat:
------------------
osaf/services/saf/immsv/immnd/ImmModel.cc | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
Testing Commands:
-----------------
See the ticket for instructions on how to reproduce.
Testing, Expected Results:
--------------------------
Continuing with immcfg in explicit commit mode is allowed even if an active
but idle CCB was aborted in the system. That is the om-handle used by immcfg
does not turn bad just because a cCB was aborted from the server side.
Conditions of Submission:
-------------------------
Ack from Neel
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 n n
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
