Summary: amf: Validate env variable format set in comptype/comp objects [#2409] Review request for Ticket(s): 2409 Peer Reviewer(s): AMF maintainers Pull request to: Gary Lee, Hans Nordeback Affected branch(es): develop, release Development branch: ticket-2409 Base revision: e61e96acac6428f53545ad9b6f4203f3032a51c3 Personal repository: git://git.code.sf.net/u/nguyenluu/review
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- revision de870ceadd4d59cacbacfad3cfed29b6e5fec615 Author: Nguyen Luu <nguyen.tk....@dektech.com.au> Date: Tue, 13 Feb 2018 10:51:49 +0700 amf: Validate env variable format set in comptype/comp objects [#2409] Valid environment variable should have the format 'var=value'. This validation shall now be done by AMF during CCB operations on SaAmfCompType (CREATE) and SaAmfComp (CREATE/MODIFY) objects regarding the saAmfxxxCmdEnv attribute. Complete diffstat: ------------------ src/amf/amfd/comp.cc | 59 +++++++++++++++++++++++++++++++++++++++++++++++- src/amf/amfd/comp.h | 2 ++ src/amf/amfd/comptype.cc | 27 +++++++++++++++++++--- 3 files changed, 84 insertions(+), 4 deletions(-) Testing Commands: ----------------- 1) Create SaAmfCompType/SaAmfComp objects with invalid env variable format in attributes saAmfCtDefCmdEnv/saAmfCompCmdEnv (e.g 'var = value', 'var==value'). 2) Modify attribute saAmfCompCmdEnv of SaAmfComp object with invalid env variable format. Testing, Expected Results: -------------------------- AMFD will reject CREATE/MODIFY CCBs with invalid env variable format. Conditions of Submission: ------------------------- Ack from an AMF maintainer. Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel