Hi Mohan,
ack for series with minor comments in the sub-patches.
Thanks
Minh
On 9/11/18 11:55 pm, Mohan Kanakam wrote:
Summary: ntf: add new test case of API saNtfInitialize() of apitest [#2958]
Review request for Ticket(s): 2958
Peer Reviewer(s):minh
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-2958
Base revision: f8a6848a1cdbff0b518c3db951e4689e260226c7
Personal repository: git://git.code.sf.net/u/mohan-hasoln/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services n
Core libraries n
Samples n
Tests y
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision ebef37fa591d4e63ee7de9ea4098000a3256b208
Author: Mohan Kanakam <mo...@hasolutions.in>
Date: Fri, 9 Nov 2018 17:19:08 +0530
ntf: add new test case of API saNtfNotificationReadFinalize() of apitest [#2958]
revision c716e7524263131754a26b61cd305988d97a206c
Author: Mohan Kanakam <mo...@hasolutions.in>
Date: Fri, 9 Nov 2018 17:16:38 +0530
ntf: add new test case of API saNtfFinalize() of apitest [#2958]
revision cf271ad8784141560fdc6e616c5920b2fe975928
Author: Mohan Kanakam <mo...@hasolutions.in>
Date: Fri, 9 Nov 2018 17:14:20 +0530
ntf: add new test case of API saNtfDispatch() of apitest [#2958]
revision 84f64a6aaa9b45ef55261764a52386030bfd0830
Author: Mohan Kanakam <mo...@hasolutions.in>
Date: Fri, 9 Nov 2018 17:12:01 +0530
ntf: add new test case of API saNtfSelectionObjectGet() of apitest [#2958]
revision 176eb07f6e212334517af33879d085932324d4ef
Author: Mohan Kanakam <mo...@hasolutions.in>
Date: Fri, 9 Nov 2018 17:08:57 +0530
ntf: add new test case of API saNtfInitialize() of apitest [#2958]
Complete diffstat:
------------------
src/ntf/apitest/tet_saNtfDispatch.cc | 10 ++++++++++
src/ntf/apitest/tet_saNtfFinalize.cc | 7 +++++++
src/ntf/apitest/tet_saNtfInitialize.cc | 8 ++++++++
src/ntf/apitest/tet_saNtfNotificationReadFinalize.cc | 7 +++++++
src/ntf/apitest/tet_saNtfSelectionObjectGet.cc | 11 +++++++++++
5 files changed, 43 insertions(+)
Testing Commands:
-----------------
./ntftest
Testing, Expected Results:
--------------------------
13 PASSED saNtfInitialize with NULL pointer to handle AND NULL callbacks and
unintilized version
5 PASSED saNtfSelectionObjectGet Finalized handle SA_AIS_ERR_BAD_HANDLE
4 PASSED saNtfDispatch - Fianlized handle SA_AIS_ERR_BAD_HANDLE
6 PASSED saNtfFinalize SA_AIS_ERR_BAD_HANDLE - unintilized handle
2 PASSED saNtfNotificationReadFinalize SA_AIS_ERR_BAD_HANDLE
Conditions of Submission:
-------------------------
Ack from maintainers
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
