Hi Mohan, A minor comment, we could use nullptr instead.
Thanks Minh On 9/11/18 11:55 pm, Mohan Kanakam wrote:
--- src/ntf/apitest/tet_saNtfInitialize.cc | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/ntf/apitest/tet_saNtfInitialize.cc b/src/ntf/apitest/tet_saNtfInitialize.cc index 8538193..c1442dc 100644 --- a/src/ntf/apitest/tet_saNtfInitialize.cc +++ b/src/ntf/apitest/tet_saNtfInitialize.cc @@ -117,6 +117,11 @@ void saNtfInitialize_12(void) { test_validate(rc, SA_AIS_ERR_VERSION); }+void saNtfInitialize_13(void) {+ rc = NtfTest::saNtfInitialize(NULL, NULL, NULL); + test_validate(rc, SA_AIS_ERR_INVALID_PARAM); +} + __attribute__((constructor)) static void saNtfInitialize_constructor(void) { test_suite_add(1, "Life cycle, initialize, API 1"); test_case_add(1, saNtfInitialize_01, "saNtfInitialize SA_AIS_OK"); @@ -142,4 +147,7 @@ __attribute__((constructor)) static void saNtfInitialize_constructor(void) { "saNtfInitialize with major version set to lower"); test_case_add(1, saNtfInitialize_12, "saNtfInitialize with version A.0.0"); + test_case_add(1, saNtfInitialize_13, + "saNtfInitialize with NULL pointer to handle AND NULL callbacks" + " and unintilized version"); }
_______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
