PLM HE/EE lock never transitions to LOCKED state if node crashes on which the
PLM lock is being done.

If a LOCK admin command from PLM is issued on a HE or EE, CLM sends a tracking
request to AMF to validate and start the shutdown. When the START track is sent
CLM waits for a response from AMF. Because the request is coming from PLM, the
time supervision is set to UNKNOWN, which means the response has no time limit.
If the node crashes before AMF responds to CLM, the PLM never gets a response
from CLM and doesn't transition the HE/EE to locked state.

CLM needs to send a response to PLM if it detects node down and there is a
pending PLM operation on that node.
---
 src/clm/clmd/clms_evt.cc | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/src/clm/clmd/clms_evt.cc b/src/clm/clmd/clms_evt.cc
index c7d2f4ceb..c2b83c22b 100644
--- a/src/clm/clmd/clms_evt.cc
+++ b/src/clm/clmd/clms_evt.cc
@@ -760,6 +760,19 @@ void clms_track_send_node_down(CLMS_CLUSTER_NODE *node) {
     --(osaf_cluster->num_nodes);
   }
 
+#ifdef ENABLE_AIS_PLM
+  if (node->admin_op == PLM) {
+    // we haven't responded to PLM -- maybe AMF crashed?
+    SaAisErrorT rc(saPlmReadinessTrackResponse(clms_cb->ent_group_hdl,
+                                               node->plm_invid,
+                                               
SA_PLM_CALLBACK_RESPONSE_ERROR));
+    if (rc != SA_AIS_OK)
+      LOG_ER("saPlmReadinessTrackResponse FAILED: %u", rc);
+
+    node->admin_op = ADMIN_OP{};
+  }
+#endif
+
   /*Irrespective of plm in system or not,toggle the membership status for
    * MDS NODE DOWN*/
   node->member = SA_FALSE;
-- 
2.17.2


-----------------------------------------------------------------------------------------------------------------------
Notice: This e-mail together with any attachments may contain information of 
Ribbon Communications Inc. that
is confidential and/or proprietary for the sole use of the intended recipient.  
Any review, disclosure, reliance or
distribution by others or forwarding without express permission is strictly 
prohibited.  If you are not the intended
recipient, please notify the sender immediately and then delete all copies, 
including any attachments.
-----------------------------------------------------------------------------------------------------------------------

_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to