Summary: imm: fix racing in sending discard-node during network split [#3012] Review request for Ticket(s): 3012 Peer Reviewer(s): Lennart, Hans, Gary Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-3012 Base revision: 91806d17b2d79138f68ff3eb3449a9a6ba3dfbf0 Personal repository: git://git.code.sf.net/u/winhvu/review
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision 827a1d4c9c4708776cb67dd27e984368c089f232 Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au> Date: Mon, 25 Feb 2019 14:27:33 +0700 imm: fix racing in sending discard-node during network split [#3012] At the time of spliting the cluster into 02 partitions but keeping a node such as PL-3 connecting with both partitions, just IMMND on PL-3 will get discard-node messages from both active IMMD on partition #1 and from standby IMMD on partition #2. That race later on caused IMMND on PL-3 crashed due to the mismatch found at finalize-sync. This patch makes a minor change at standby IMMD - rather then sending the discard-node message even in standby role, will put the message in queue and only broadcast it when the standby is assigned to active. Complete diffstat: ------------------ src/imm/immd/immd_proc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Testing Commands: ----------------- Refer to the ticket description. Testing, Expected Results: -------------------------- No coredump is generated. Conditions of Submission: ------------------------- Ack from peer reviewers. Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel