Hi Vu

Ack (review only)

Thanks

On 25/2/19, 6:30 pm, "Vu Minh Nguyen" <[email protected]> wrote:

    At the time of spliting the cluster into 02 partitions but keeping a node
    such as PL-3 connecting with both partitions, just IMMND on PL-3 will get
    discard-node messages from both active IMMD on partition #1 and from standby
    IMMD on partition #2.
    
    That race later on caused IMMND on PL-3 crashed due to the mismatch
    found at finalize-sync.
    
    This patch makes a minor change at standby IMMD - rather then sending the
    discard-node message even in standby role, will put the message in queue
    and only broadcast it when the standby is assigned to active.
    ---
     src/imm/immd/immd_proc.c | 2 +-
     1 file changed, 1 insertion(+), 1 deletion(-)
    
    diff --git a/src/imm/immd/immd_proc.c b/src/imm/immd/immd_proc.c
    index c16232d2d..69e23f2d3 100644
    --- a/src/imm/immd/immd_proc.c
    +++ b/src/imm/immd/immd_proc.c
    @@ -778,7 +778,7 @@ uint32_t immd_process_immnd_down(IMMD_CB *cb, 
IMMD_IMMND_INFO_NODE *immnd_info,
                }
        }
     
    -   if (active || !cb->immd_remote_up) {
    +   if (active) {
                /*
                 ** HAFE - Let IMMND subscribe for IMMND up/down events instead?
                 ** ABT - Not for now. IMMND up/down are only subscribed by
    -- 
    2.19.2
    
    




_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to