Summary: amf: realign sg if si_dep_state of si in FAILOVER_UNDER_PROGRESS
[#3054]
Review request for Ticket(s): 3054
Peer Reviewer(s): Gary, Minh, Hans
Pull request to: Minh
Affected branch(es): develop
Development branch: ticket-3054
Base revision: 4f86e371d28a385f689011a0effef8aaae65e713
Personal repository: git://git.code.sf.net/u/thangng/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
revision 8edd4e5f8484c37b3b7726c835baf46225e2c92c
Author: thang.d.nguyen <thang.d.ngu...@dektech.com.au>
Date: Tue, 2 Jul 2019 21:53:31 +0700
amf: realign sg if si_dep_state of si in FAILOVER_UNDER_PROGRESS [#3054]
With SI dependency, when failover happen the failover is processed
on SU had sponsor SI first. It also update the si_dep_state of
dependent SI to FAILOVER_UNDER_PROGRESS. Then failover is processed
on SU had dependent SI. But failover is deferred as sponsors role
failover is under going.
Amfd crashes when the SU had dependent SI was instantiated on standy
node while the assignment ACTIVE sponsor SI for SU on ACTIVE node
still assigning.
Complete diffstat:
------------------
src/amf/amfd/sg.cc | 13 +++++++++++++
src/amf/amfd/sg.h | 1 +
src/amf/amfd/sgproc.cc | 6 +++++-
3 files changed, 19 insertions(+), 1 deletion(-)
Testing Commands:
-----------------
N/A
Testing, Expected Results:
--------------------------
N/A
Conditions of Submission:
-------------------------
Acked from reviewer
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
