Hi Minh

Ack with comment. Please include this explaination.

+    // a reboot is required, as clmna on other nodes may not start
+    // an election because it thinks this node is going to be active
+    opensaf_quick_reboot("Another controller is already active");

Thanks
Gary

________________________________
From: Minh Chau <minh.c...@dektech.com.au>
Sent: 16 January 2020 13:06
To: Gary Lee <gary....@dektech.com.au>; hans.nordeb...@ericsson.com 
<hans.nordeb...@ericsson.com>; Vu Minh Nguyen <vu.m.ngu...@dektech.com.au>
Cc: opensaf-devel@lists.sourceforge.net <opensaf-devel@lists.sourceforge.net>; 
Minh Hon Chau <minh.c...@dektech.com.au>
Subject: [PATCH 1/1] rde: Reboot node if another active controller is detected 
[#3142]

---
 src/rde/rded/role.cc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/rde/rded/role.cc b/src/rde/rded/role.cc
index b890117..9446ccb 100644
--- a/src/rde/rded/role.cc
+++ b/src/rde/rded/role.cc
@@ -107,6 +107,7 @@ void Role::PromoteNode(const uint64_t cluster_size,
   rc = consensus_service.PromoteThisNode(true, cluster_size);
   if (rc == SA_AIS_ERR_EXIST) {
     LOG_WA("Another controller is already active");
+    opensaf_quick_reboot("Another controller is already active");
     return;
   } else if (rc != SA_AIS_OK && relaxed_mode == true) {
     LOG_WA("Unable to set active controller in consensus service");
--
2.7.4


_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to