Hi Khanh,

ACK from me

Best Regards,
Thien

-----Original Message-----
From: Khanh Q Nguyen <khanh.q.nguy...@dektech.com.au> 
Sent: Monday, April 17, 2023 2:10 PM
To: Thang Duc Nguyen <thang.d.ngu...@dektech.com.au>; Thien Minh Huynh 
<thien.m.hu...@dektech.com.au>
Cc: opensaf-devel@lists.sourceforge.net; Khanh Q Nguyen 
<khanh.q.nguy...@dektech.com.au>
Subject: [PATCH 1/2] rde: fix pointer used after free [#3332]

This fix moves the free function to a more appropriate position.
---
 src/rde/agent/rda_papi.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/rde/agent/rda_papi.cc b/src/rde/agent/rda_papi.cc index 
ef5d8a962..80d98ca52 100644
--- a/src/rde/agent/rda_papi.cc
+++ b/src/rde/agent/rda_papi.cc
@@ -284,8 +284,8 @@ static PCSRDA_RETURN_CODE pcs_rda_reg_callback(uint32_t 
cb_handle,
     }
 
     if (m_NCS_TASK_START(rda_callback_cb->task_handle) != NCSCC_RC_SUCCESS) {
-      m_NCS_MEM_FREE(rda_callback_cb, 0, 0, 0);
       m_NCS_TASK_RELEASE(rda_callback_cb->task_handle);
+      m_NCS_MEM_FREE(rda_callback_cb, 0, 0, 0);
       rc = PCSRDA_RC_TASK_SPAWN_FAILED;
       break;
     }
--
2.17.1



_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to