Ack.

-----Original Message-----
From: Khanh Q Nguyen <khanh.q.nguy...@dektech.com.au> 
Sent: Monday, April 17, 2023 2:10 PM
To: Thang Duc Nguyen <thang.d.ngu...@dektech.com.au>; Thien Minh Huynh 
<thien.m.hu...@dektech.com.au>
Cc: opensaf-devel@lists.sourceforge.net; Khanh Q Nguyen 
<khanh.q.nguy...@dektech.com.au>
Subject: [PATCH 2/2] evt: fix pointer used after free [#3332]

This fix moves the free function to a more appropriate position.
---
 src/evt/evtd/eds_amf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/evt/evtd/eds_amf.c b/src/evt/evtd/eds_amf.c index 
97b71a5bd..ebadf9095 100644
--- a/src/evt/evtd/eds_amf.c
+++ b/src/evt/evtd/eds_amf.c
@@ -865,10 +865,10 @@ SaBoolT update_node_db(EDS_CB *cb, NODE_ID node_id, 
SaBoolT is_member)
                        if (ncs_patricia_tree_add(&cb->eds_cluster_nodes_list,
                                                  &cn->pat_node) !=
                            NCSCC_RC_SUCCESS) {
-                               free(cn);
                                LOG_ER(
                                    "Patricia add failed for cluster node %u",
                                    cn->node_id);
+                               free(cn);
                                TRACE_LEAVE();
                                return SA_FALSE;
                        } else {
--
2.17.1



_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to