Hi Minh,
I also wouldn't prefer to rollback but because of internal
implementation, I am just reusing the code. I am preferring return code as
TRY_AGAIN because the error has occurred and the operation can't be completed.
Thanks
-Nagu
From: Minh Hon Chau [mailto:minh-c...@users.sf.net]
Sent: 02 February 2017 09:56
To: opensaf-tickets@lists.sourceforge.net
Subject: [tickets] [opensaf:tickets] Re: #2133 AMF: Rollback admin
shutdown/lock SI operation if node failover
Hi Nagu,
I prefer to not rollback the operations (as commented by Praveen earlier) if
the rollback is due to internal implementation, not from a specific use case.
Anyway if we have no way to correct it, then we have to accept it. I don't have
a clear indication on which error code should be returned, both TRY_AGAIN and
TIMEOUT seems ok since the caller will have to retry the operation.
Thanks,
Minh
_____
HYPERLINK "https://sourceforge.net/p/opensaf/tickets/2133/"[tickets:#2133] AMF:
Rollback admin shutdown/lock SI operation if node failover
Status: accepted
Milestone: 5.2.FC
Created: Thu Oct 20, 2016 06:49 PM UTC by Minh Hon Chau
Last Updated: Wed Feb 01, 2017 08:50 AM UTC
Owner: Nagendra Kumar
In scenario of shut down SI, delay QUIESCING csi callback, then reboot the node
that hosting SU having pending this csi callback. The result of this operation
looks differently between SGs
- For 2N: the SI Admin state is rollbacked to UNLOCK
- For Nway: the SI Admin state moves to LOCKED
- In NpM: Haven't tested just browsing SG_NPM::node_fail_si_oper, looks SI
Admin states rollbacks to UNLOCK
My question is whether the result of these scenario should be consistent? And
what's the expected outcome?
Also, the handling of node_fail_si_oper for admin lock is not consistent. For
2N, Admin state remains LOCKED, NpM rollbacks to UNLOCK
_____
Sent from sourceforge.net because HYPERLINK
"mailto:opensaf-tickets@lists.sourceforge.net"opensaf-tickets@lists.sourceforge.net
is subscribed to https://sourceforge.net/p/opensaf/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.
---
** [tickets:#2133] AMF: Rollback admin shutdown/lock SI operation if node
failover**
**Status:** accepted
**Milestone:** 5.2.FC
**Created:** Thu Oct 20, 2016 06:49 PM UTC by Minh Hon Chau
**Last Updated:** Thu Feb 02, 2017 09:56 AM UTC
**Owner:** Nagendra Kumar
In scenario of shut down SI, delay QUIESCING csi callback, then reboot the node
that hosting SU having pending this csi callback. The result of this operation
looks differently between SGs
- For 2N: the SI Admin state is rollbacked to UNLOCK
- For Nway: the SI Admin state moves to LOCKED
- In NpM: Haven't tested just browsing SG_NPM::node_fail_si_oper, looks SI
Admin states rollbacks to UNLOCK
My question is whether the result of these scenario should be consistent? And
what's the expected outcome?
Also, the handling of node_fail_si_oper for admin lock is not consistent. For
2N, Admin state remains LOCKED, NpM rollbacks to UNLOCK
---
Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is
subscribed to https://sourceforge.net/p/opensaf/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets