I'm no big fan of the new patch - one function knows about the
internals of the other function?

Instead I see two ways:
a) we get a return code so we can evaluate whether to free app or not.
b) the called function is always responsible for either using or freeing
    app so we don't need to free(app) even if we get an error.

> > right, might not be a good strategy anyway.
> > change the code to display as much as we can?
> > log a second line about output being truncated?
>
> I'm not sure but I think it would make sense to show as much information
> as possible and perhaps (optional) give a hint that the information has
> been truncated.

good idea.

Andreas
_______________________________________________
opensc-devel mailing list
[email protected]
http://www.opensc-project.org/mailman/listinfo/opensc-devel

Reply via email to