Andreas Jellinghaus wrote:
I'm no big fan of the new patch - one function knows about the
internals of the other function?
as one of these functions is an internal function I don't consider
this a big problem
Instead I see two ways:
a) we get a return code so we can evaluate whether to free app or not.
this would require that we examine every possible return value
of every functions called within the function .... not really
practical.
b) the called function is always responsible for either using or freeing
app so we don't need to free(app) even if we get an error.
well a better solution would be if the function would create it's
own copy of the structure but as there isn't a copy/dup function
for this structure this is little bit awkward ...
Cheers,
Nils
_______________________________________________
opensc-devel mailing list
[email protected]
http://www.opensc-project.org/mailman/listinfo/opensc-devel
