Moin, Am Wed, 27 Sep 2006 23:34:36 +0200 schrieb Andreas Jellinghaus:
> could someone please review this patch? > maybe it is a nice addition we want to integrate? > > http://cvs.mandriva.com/cgi-bin/viewvc.cgi/SPECS/opensc/opensc-0.10.0-pinstdin.patch?view=markup No objection to the idea in general, but I propose to at least change if (opt_pincode[0] == '-') to if (strcmp(opt_pincode, "-") == 0) Otherwise it would be impossible to use a real pin that starts with '-' In the long term it would be best to use Martin's openssl-like approach which offers proper escaping so there are no special values that can't be used as pin. -- Henryk Plötz Grüße aus Berlin ~~~~~~~ Un-CDs, nein danke! http://www.heise.de/ct/cd-register/ ~~~~~~~ ~ Help Microsoft fight software piracy: Give Linux to a friend today! ~
pgpuACCxumYpL.pgp
Description: PGP signature
_______________________________________________ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
