On Thursday 21 June 2007 15:26:54 Ludovic Rousseau wrote:
> You may have less warnings but now more errors :-)

yes, I was more or less working incrementally with fixing some warnings, 
committing, testing etc. my regression tests use a fresh checkout, so I need 
to commit before testing, which is somehow not optimal. maybe I should use
a distributed SCM instead.

> You can't have a variable declared static if you also want to use it
> from another source file. app_name is also used by util.c

yes, I realized that too late. thanks for fixing it too. with your latest 
changes we can mark app_name and friends static in all tools/*.c
and thus kill those warnings.

the last open warnings I'm aware off:
 - two warnings concerning some not defined setting in cardos code.
 - some warnings with openssl functions and wrong parameter types.
   but I have no clue why, those all look fine to me (d2i_X509 or something
   and seveal X509_* functions).  if you get those warnings too from gcc or
   sparse: any idea why we get it? what is wrong?

Anyway, that collection of small changes fixed about 600 warnings, even if 
most are harmless (like 0 instead of NULL).

Regards, Andreas
_______________________________________________
opensc-devel mailing list
[email protected]
http://www.opensc-project.org/mailman/listinfo/opensc-devel

Reply via email to