On Mon, Aug 18, 2008 at 10:25 PM, Andreas Jellinghaus <[EMAIL PROTECTED]> wrote: > Am Freitag, 15. August 2008 07:14:12 schrieb Weitao Sun: >> Hello, >> >> The attachment is the patch file. Let me know if you have any comments. >> Thank you. > > Hi Weitao, > > thanks for sending the diff. a few small comments:
Same comments as Andreas. Why do you need to patch src/pkcs15init/pkcs15-lib.c? @@ -2793,9 +2794,13 @@ r = sc_pkcs15_encode_df(card->ctx, p15card, df, &buf, &bufsize); if (r >= 0) { + sc_file_t *file; + r = sc_profile_get_file_by_path(profile, &df->path, &file); + if(r<0) return r; r = sc_pkcs15init_update_file(profile, card, - df->file, buf, bufsize); + file, buf, bufsize); free(buf); + sc_file_free(file); } return r < 0 ? r : 0; Bye -- Dr. Ludovic Rousseau _______________________________________________ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel