On 12/6/08, Martin Paljak <[EMAIL PROTECTED]> wrote:
> Right.
>
>  As it affect the overall operation of pkcs11-tool (C_GetSlotList is called
> only once during the lifetime of the tool)
>  it is justified to have it as a generic option to pkcs11-tool. I'm just not
> sure if adding a verbose option is the right thing to do.
>  If you actually use pkcs11-tool (as a human being) one often wants to cut
> the unnecessary noise (e.g. 13 empty virtual slots)
>  So it also makes sense to have it as a shorthand option.

I understand this... But having too many options is also makes it
difficult for people to use the tool.

>  So pkcs11-tool -TL (--list-slots --with-tokens?) is the way I'd like to
> type it.  What do you think?

OK.
Although the name of the new parameter should be related slots... And
I like to have a more generic parameter exactly as we have to object
type.

>  Similarly to the change in [3597] I'd like to change pkcs11-tool -O for
> example to display all objects in all slots, unless a slot is specified.

I've seen this... You mean all objects in first none empty slot...
Well, I must say I did not like this... But it did not made any
damage. I don't like the goto you added there.... :) Better is to
search using another variable...

But anyway, I don't think that printing all objects in all slots is
consistent with expected behavior.

Alon.

>
>  m.
>
>  On 06.12.2008, at 21:03, Alon Bar-Lev wrote:
>
>
> > Martin,
> >
> > Can you please change this implementation by removing the
> > --list-token-slots and add extra parameter to --list-slots?
> >
> > pkcs11-tool --list-slots --slot-status={empty,token}
> >
> > Alon.
> >
> > On 11/22/08, Alon Bar-Lev <[EMAIL PROTECTED]> wrote:
> >
> > > On 11/22/08, [EMAIL PROTECTED] <[EMAIL PROTECTED]>
> wrote:
> > >
> > > > Revision: 3592
> > > > Author:   martin
> > > > Date:     2008-11-21 23:34:31 +0100 (Fri, 21 Nov 2008)
> > > >
> > > > Log Message:
> > > > -----------
> > > > Add --list-token-slots / -T to pkcs11-tool to list only slots with
> tokens.
> > > >
> > > >
> > >
> > >
> > > I think this should be an option for --list-slots and not another
> > > standalone option.
> > >
> > >
> > > Alon.
> > >
> > >
> >
>
>  --
>  Martin Paljak
>  http://martin.paljak.pri.ee
>  +372.515.6495
>
>
>
>
>
_______________________________________________
opensc-devel mailing list
opensc-devel@lists.opensc-project.org
http://www.opensc-project.org/mailman/listinfo/opensc-devel

Reply via email to