I will try to add some comments but for now I'm not sure to have A lot of time for this but I will try... I would prefer had this
later. Ok for the wiki page I will have a lock. I don't use " the command line parsing shared tool" because I've started integrating in a stand alone librairie not in opensc source, but later if I've some time I will rewrite this part... "westcos-tool" is necessary because of westcos card with only 2ko can't have the complete pkcs15 structure and so have only one private key and a certificate. We have javacard applet and virtual software westcos card whitch use opensc tools with complete pkcs15 structure. Regards, François. -----Message d'origine----- De : Andreas Jellinghaus [mailto:a...@dungeon.inka.de] Envoyé : mardi 8 septembre 2009 16:51 À : opensc-devel@lists.opensc-project.org Cc : François Leblanc Objet : Re: [opensc-devel] Patch adding support for westcos card. much better. I found a few more small issues: * can you edit doc/tools/ and document the new tool too? * can you translate the texts in westcos-tool into english? (we don't have i18n and l10n so far in opensc code, but you could keep the french texts to and use a -DENGLISH or -DFRENCH define to switch) * check the documentation once more? e.g. in the code you have empty comments /* */ where you could write e.g. which define ends there. or make sure each new file has a proper summary line in the copyright header. if you want, we have some shared code used by all tools to do the command line parsing and options etc. that could be used by westcos-tool too. (but if you want to keep your stile that is fine for me as well). later we will need a wiki page to document the card, how it is supported, where people can buy it, and what they need to know to use it. for example when should people use the westcos-tool and when can they use the standard opensc tools? or what happends if people use opensc-pkcs11.so api to do the key generation etc/ is there any downside to that? also I'm not sure what westcos-tool does with the configuration code and why it is needed. shouldn't a proper new config file for opensc has everything needed? Regards, Andreas _______________________________________________ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
