On Nov 30, 2010, at 3:59 PM, Ludovic Rousseau wrote: > 2010/11/30 Martin Paljak <[email protected]>: >> >> On Nov 30, 2010, at 3:30 PM, Ludovic Rousseau wrote: >> >>> 2010/11/25 Andre Zepezauer <[email protected]>: >>>> Thanks for help. Please remove these two lines: >>>> http://www.opensc-project.org/opensc/browser/trunk/src/libopensc/card-entersafe.c#L137 >>> >>> pkcs15-init: card-entersafe.c:383: entersafe_read_binary: Assertion >>> `count <= card->max_recv_size' failed. >> Production code should be compiled with --disable-assert. In that specific >> case the assert should take into account the "no restrictions" limit. > > I don't know if the point has already been discussed. I was not aware > of the --disable-assert option. > > Maybe we should use the reverse: > > - Development code is configured with --enable-assert > - Production code is compiled with no extra option
Unfortunately the default macro does it the other way around, it is enabled by default and there's no way that it can easily be reversed I know of. You can find threads discussing it from the web. So scripts that generate packages should explicitly set --disable-assert (as they are generating a production package) The other issue is the current amount and nature of assert()-s in the code, their usefulness and whether code with asserts should leave developers workstation. -- @MartinPaljak.net +3725156495 _______________________________________________ opensc-devel mailing list [email protected] http://www.opensc-project.org/mailman/listinfo/opensc-devel
