Ludovic, change,44 below is Vicktor's, not mine. I should not have said "I think I have to rebase the code, and do another pull request?"
I was hopping you would try a +2 on: https://www.opensc-project.org/codereview/#change,237 Its parent is: 6f8dcc9172277799011d88fdbe2fabfcf3a89774 Make the Mac OS X package builder script more resilient. which is the gerrit staging branch, so it should not need to be rebased. On 2/21/2012 5:43 AM, Douglas E. Engert wrote: > > > On 2/21/2012 2:34 AM, Ludovic Rousseau wrote: >> Le 20 février 2012 22:31, Peter Stuge<pe...@stuge.se> a écrit : >>> Douglas E. Engert wrote: >>>> I am new to Gerrit too, >>> >>> All right! I'm by no means an expert, but I have been using it in >>> several projects for a while, where I also helped with issues during >>> the migration, so please feel free to ask any questions. >>> >>> >>>> but it looks like if 2 code reviews give a +1, the code will be >>>> advanced. >>>> >>>> See: https://www.opensc-project.org/codereview/ >>> >>> Need Code Review +2 means that one "+2" review is neccessary. 2x +1 >>> is not equivalent. >> >> OK. >> Using +2 (instead of +1) now shows some progress. >> >> Example with https://www.opensc-project.org/codereview/#change,44 >> If I click on "Submit Patch Set 1" I now get the error: >> "Submit Failed >> Project policy requires all submissions to be a fast-forward. >> >> Please rebase the change locally and upload again for review." >> >> What should I do now? > > I think I have to rebase the code, and do another pull request? > >> >> It looks like gerrit worked for another patch: >> https://www.opensc-project.org/codereview/#change,2 >> The status is "Submitted, Merge Pending" >> Do I have to do something? >> Who will do the merge? >> >> Thanks >> > -- Douglas E. Engert <deeng...@anl.gov> Argonne National Laboratory 9700 South Cass Avenue Argonne, Illinois 60439 (630) 252-5444 _______________________________________________ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
