Hello, Le 23 mars 2012 21:53, "Magosányi, Árpád" <m4g...@gmail.com> a écrit : > I have registered to gerrit, because saying stuff is one thing, doing it > is another. I guess I am supposed to verify and/or review. Which is > what, and how? > I have choosen Change I1e6f787d to experiment with, which is a nice > oneliner. Some guy have changed an email address in a comment to his own. > I believe reviewing means I should take a look at the patch to ensure > that it is up to the standards. > Well, I don't know the standards still, but as it is in the same form > as the previous, I would think it is. so my verdict here is PASS. > Also I believe verifying normally means testing the patch. But in this > case maybe verifying the authenticity of the contact change would be the > correct way. > So I write an email to the old guy, and to the email address in the > same source code which is from the same domain, and to some guy I guess > is associated with the driver in question. If any one says yes and none > says no, then I will push the verify button. > > Is it what someone supposed to do with this gerrit thingie?
I think you are doing the good thing. Thanks. For the others, the patch Árpád refers to is discussed at https://www.opensc-project.org/codereview/#/c/252/ I encourage every user of the opensc-devel list to: - create a gerrit account - subscribe to the Email notifications. Go in Settings -> Watched Projects and check the 3 notifications boxes for the OpenSC project - review patches and add comments I was not subscribed to the notifications at the beginning and then missed a lot of patch submissions. If you want to follow the OpenSC development is very important to subscribe to gerrit notifications (I think). Regards, -- Dr. Ludovic Rousseau _______________________________________________ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
