Another comments:
- some laptops do not allow changing LCD brightness via ACPI in graphics
mode (e.g. due to graphics driver). So I wonder if you could provide
some command line API to do this? Gnome applet will not save a user of
such laptop.
- on some laptops, you need to do various tricks to read Fn key events and
such laptops will likely need extra driver. How can one from this
unbundled module bind keypress to e.g. change LCD brightness? Assume
that there is no ACPI event for brightness up/down. Shouldn't we
provide kernel API as well?
Maybe it's worth considering to split ACPI functionality to several
modules like:
acpi_vid{eo} for switching video outputs/changing brightness
acpi_bat{t} for handling battery
etc..
Thanks,
Vita
On Tue, 15 Jan 2008, Phi Tran wrote:
> Garrett D'Amore wrote:
>> A better name would be acpipower or somesuch. But that's a minor detail.
>>
>> -- Garrett
>
> Agreed. Most likely acpi_drv since I don't want to confuse acpidrv folks who
> use Casper's frkit :)
>
> Phi
>
>>
>> Phi Tran wrote:
>>
>>>
>>>>> This sounds a bit strange for me. The battery driver will change LCD
>>>>> brightness. Why the battery driver? What is the relation between battery
>>>>> driver and LCD brightness? What will happen if you will run your laptop
>>>>> without a battery? Maybe I do not understand the battery driver
>>>>> concept...
>>>>
>>>>
>>>>
>>>> The battery driver was first developed to handle ACPI battery events.
>>>> Now support for lid and brightness ACPI events are being added to the
>>>> battery driver which supports laptops. Yes, the name could probably be
>>>> changed in the future.
>>>
>>>
>>> For laptops, even if the battery is not there, the battery subsystem
>>> will be there. The battery driver has to handle events such as AC
>>> adapter when ther battery is removed and also events such as when the
>>> battery is added.
>>>
>>> Phi
>>
>>
>
>
