Sebastien Roy wrote:
> On Mon, 2009-06-08 at 18:50 -0700, Erik Nordmark wrote:
>
>> Sebastien Roy wrote:
>>
>>
>>> To support this, the command 'dladm show-linkprop' will now display
>>> two additional properties "lso" and "hw_tx_cksum" for each driver.
>>> This is achieved by adding two new MAC properties MAC_PROP_LSO and
>>> MAC_PROP_HCKSUM to the enum mac_prop_id_t in
>>> /usr/src/uts/common/sys/mac.h. These properties will apply to all
>>> datalinks of type DL_ETHER.
>>>
>> Doesn't the IPoIB drivers support hardware checksum? Why would we want
>> to limit the property to DL_ETHER?
>>
>
> This was my oversight, I had asked Vasumathi to specify whether there
> were any link class or media restrictions for the properties, which led
> to the DL_ETHER specification. In fact, I think (and Vasumathi can
> correct me) that the property shows up for links that have drivers that
> support the property, regardless of class or media (i.e., they don't
> return ENOTSUP in their mac property callbacks).
>
> -Seb
>
>
>
As Sebastian mentioned, I think we should say that the property applies
to all datalinks that support hardware checksum (DATALINK_ANY_MEDIATYPE)
and not limit it to any one type.
