On Mar 28, 2010, at 13:12:16 -0600, Tim Haley wrote:

Please find documentation nits in-line below...

 - Don

 ... ... ...
> 
> 4. Technical Description
> 
>         There is a long-standing RFE for zfs to be able to describe
>         what has changed between the snapshots of a dataset.
>         To provide this capability, we propose a new 'zfs diff'
>         sub-command.  When run with appropriate privilege the
>         sub-command describes what file system level changes have
>         occurred between the requested snapshots.  A diff between the
>         current version of the file system and one of its snapshots is
>         also supported.
> 
>         Five types of change are described:
> 
>         o    File/Directory modified
>         o    File/Directory present in older snapshot but not newer
>         o    File/Directory present in newer snapshot but not older
>         o    File/Directory renamed

A directory is a type of file.  Saying "File/Directory" is a long way
of saying "File".  The other possibility is that you meant "Regular
File/Directory", but that would only be appropriate if you mean that
zfs diff does not report changes to symbolic links, character special
file, block special files, doors, FIFOs, sockets, and any other types
of files zfs supports.

>         o    File link count changed
> 
>         Diffs can be performed if the user is delegated the "diff"
>         permission.  The "diff" permission is being introduced by this
>         case.  Diffs can also be performed without the "diff"
>         permission, if the user has appropriate privilege.  For diffs
>         between existing snapshots, the necessary privilege is
>         {PRIV_SYS_CONFIG}.  For diff between the current file system
>         and a snapshot {PRIV_SYS_MOUNT} is also necessary.
> 
>         Also introduced by this case is a system attribute on zfs files
>         called 'generation'.  This attribute is part of the
>         XATTR_VIEW_READONLY described in PSARC 2007/315.  It is
>         generated automatically by the ZFS module.
> 
> Man page changes:
 ... ... ...
> --- zfs.1m.rogi Sun Mar 21 17:01:04 2010
> +++ zfs.1m      Sun Mar 28 12:20:04 2010
> @@ -165,6 +165,9 @@
>       zfs release [-r] tag snapshot...
> 
> 
> +     zfs diff snapshot snapshot|filesystem
> +
> +
>  DESCRIPTION
>       The zfs command configures ZFS datasets within a ZFS storage
>       pool,  as described in zpool(1M). A dataset is identified by
> @@ -1638,7 +1641,41 @@
>               size, the resulting behavior is undefined.
> 
> 
> +     zfs diff snapshot  snapshot | filesystem
> 
> +         Gives a high level description of the differences between a
> +         snapshot and a descendant dataset.  The descendant may either
> +         be a later snapshot of the dataset or the current dataset.
> +         For each file system object that has undergone a change
> +         between the original snapshot and the descendant, the type of
> +         change is described along with the name of the file or
> +         directory.  In the case of a rename, both the old and new
> +         names are shown.
> +
> +         The type of change is described with a single character:
> +
> +         +   Indicates the file/directory was added in the later dataset
> +         -   Indicates the file/directory was removed in the later dataset
> +         M   Indicates the file/directory was modified in the later dataset
> +         R   Indicates the file/directory was renamed in the later dataset

Again, "file/directory" should just be "file" in all four lines above.

> +
> +        If the modification involved a change in the link count of a
> +        file, the change will be expressed as a delta within
> +        parentheses on the modification line.  Example outputs are
> +        below:
> +
> +         M       /myfiles/
> +         M       /myfiles/link_to_me   (+1)
> +         R       /myfiles/rename_me -> /myfiles/renamed
> +         -       /myfiles/delete_me
> +         +       /myfiles/new_file
 ... ... ...

Reply via email to