Rainer Orth wrote:
Files missing from the proto area:

T File Name                      Reloc/Sym name       perm owner group inode 
lnk maj min package(s)
------------------------------------------------------------------------------------------------------------
d etc/llc2/default               -                     755 -     -          0  
1  -  -    SUNWllcr

  SUNWllcr can be built, but this directory is missing.  I suppose it is
  usually created from the closed tree.  It is now missing from the closed
  tarball, so it should probably be added to Targetdirs?

Interesting. This used to be present in previous closed-bins tarballs, but seems to be missing in the most recent delivery. I'll try to track this down and see why it disappeared.

Apart from the smartcard stuff (which we might actually ignore since it's
on its way out), the main offenders are SUNWonmtst.i (which only lacks
usr/bin/mtst, and could perhaps be opened) and SUNWiotu (which lacks
usr/sbin/pcitool and the corresponding man page).

Yup. I would ignore smartcard for now since it's slated to be removed soon. usr/bin/mtst and usr/sbin/pcitool are explicitly not opened, nor included in the closed-binaries tarball...

If I do this, the protocmp warnings are gone as expected.  Unfortunately,
if I run nightly -i at this point, I get at another problem: makebfu fails
like this:

==== cpio archives build errors (DEBUG) ====

Failed to create generic kernel archive:        133230 blocks
Failed to create generic root archive:  4320 blocks
Failed to create generic usr archive:   328400 blocks
Failed to create i86pc root archive:    10410 blocks
Failed to create i86pc usr archive:     2200 blocks
cpiotranslate: kernel/crypto/amd64/dprov: no packaging info

So it seems we cannot move the closed packages to usr/closed/pkgdefs (at
least not those which have any component either in the open tree or the
closed tarball).  If we leave them all in usr/src/pkgdefs, the open
exception list gets quite long and needs to duplicate the whole list of
files and directories from closed packages.  So the approach seems to be to
only move packages that are completely closed, and leave the rest in
usr/src/pkgdefs.  This uglifies usr/src/pkgdefs/Makefile quite a bit,
though:

I had initially planned to use something like the following:

SUBDIRS= $($(MACH)_SUBDIRS) $(COMMON_SUBDIRS)
$(CLOSED_BUILD)SUBDIRS+= \
        $($(MACH)_CLOSED_SUBDIRS:%=$(CLOSED)/pkgdefs/%) \
        $(COMMON_CLOSED_SUBDIRS:%=$(CLOSED)/pkgdefs/%)

If we need to distinguish between completely closed packages and partially
closed packages, we either need to create additional make variables to list
them separately and prefix/move only the completely closed ones, or prefix
every completely closed package in thosed *_CLOSED_SUBDIRS lists like this:

CLOSED_COMMON_XMODS= \
        SUNWcryptoint \
        $(CLOSED)/pkgdefs/SUNWsvvs

Which solution do you prefer?

I agree, I don't like the idea of duplicating the open exception list... that seems like a bad maintenance problem long term. My personal preference is to create additional make variables to denote the completely-closed packages from the partially-closed packages and move the completely closed ones. Mike may have a better opinion though...

cheers,
steve

--
stephen lau // [EMAIL PROTECTED] | 650.786.0845 | http://whacked.net
opensolaris // solaris kernel development
_______________________________________________
opensolaris-code mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/opensolaris-code

Reply via email to