> Generally, all devices that are "interesting" are likely to have some > upper layer plumbed on them. Networking devices have IP. Disks have > filesystems, etc.
I agree, but I still find it confusing to couple the resetting of kstats with events that cannot necessarily be administratively predicted or easily observed. Your original problem statement centered around the update_drv case, for which the intended administrative semantics seem much more clear-cut. Hence my suggestion to destroy the persistent kstats in that case. > If the device isn't in use, then probably the historical data simply is > not interesting. Personally, I'm not swayed by that argument. Solaris is inherently dynamic; assuming that collected data for a particular device is no longer interesting just because the device is not currently being used seems flawed. (I'm certainly not in love with KSTAT_FLAG_PERSISTENT, but I do think it serves a purpose of ensuring that data is not lost unexpectedly.) Perhaps others feel differently. > Also, the use of KSTAT_FLAG_PERSISTENT is itself, very inconsistent > among device drivers. OK, but that's a separate matter -- the original argument here was that KSTAT_FLAG_PERSISTENT is inherently flawed, not that it's merely applied inconsistently. -- meem _______________________________________________ opensolaris-code mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/opensolaris-code
