> On March 24, 2012, 7:22 a.m., Jonathan Yap wrote: > > It seems to me that the better fix would be to support the URLs, as you say > > some TPVs do, that are currently causing trouble.
You can still login to non-Linden Lab grids via the --login URI parameter https://wiki.secondlife.com/wiki/Viewer_parameters But the grid selection combo doesn't support adding custom grids with a 'corrupt' format at all, as it seems the whole viewer is NOT designed for non-Linden Lab grids, see here: https://jira.secondlife.com/browse/VWR-28570?focusedCommentId=315423&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-315423 The hack to support these non-Linden Lab grid-format-urls as suggested here is an attempt to try parsing input data of any given format - be it valid or not - and a guessing game what the users input might mean, and that's in my honest opinion more of a 'political' question for the Linden Lab managment, and not a crash-fix-issue: https://jira.secondlife.com/browse/STORM-1818?focusedCommentId=314515&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-314515 Please test the fix/ship it. Thanks in advance. Kind regards, MartinRJ - MartinRJ ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/563/#review1177 ----------------------------------------------------------- On March 24, 2012, 5:33 a.m., MartinRJ Fayray wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/563/ > ----------------------------------------------------------- > > (Updated March 24, 2012, 5:33 a.m.) > > > Review request for Viewer. > > > Description > ------- > > FIX FOR STORM-1818 (https://jira.secondlife.com/browse/storm-1818) "Abnormal > program termination when I enter an URL to the grid selection combobox > (login-screen) and press enter." > > Repository with fix: https://bitbucket.org/MartinRJ/storm-1818/ > > About: > When entering a malformed grid dns address, the viewer needs to catch the > malformed address. Currently it throws an error in a subroutine of the > grid-address-handling (llviewernetwork.cpp, function 'addGrid') and crashes > without warning due to a thrown error ("throw LLInvalidGridName(grid);"). > > This fix adds code to: > notifications.xml (a warning message text/notification: "IllegalGridName"), > llviewernetwork.h (a function which checks whether a given grid exists, by > name (string): bool getGridExists), > llpanellogin.cpp (an include for llviewernetwork.h, and a check against an > invalid grid dns address in function onSelectServer). > > Todo: Maybe edit the notification message, and update the language files. > > > This addresses bug STORM-1818. > http://jira.secondlife.com/browse/STORM-1818 > > > Diffs > ----- > > indra/newview/llpanellogin.cpp acfb0781d850 > indra/newview/llviewernetwork.h acfb0781d850 > indra/newview/skins/default/xui/en/notifications.xml acfb0781d850 > > Diff: http://codereview.secondlife.com/r/563/diff/diff > > > Testing > ------- > > Test plan: Insert a malformed grid dns address (e.g. > http://grid.francogrid.org:8002 which works with some TPVs) into the grid > selection combo on the login screen. > Expected behaviour: a popup shows up, informing about the malformed address, > and the grid selection combo swaps back to the default grid (Agni). > > > Thanks, > > MartinRJ Fayray > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
