----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/563/#review1184 -----------------------------------------------------------
Thanks for looking at this issue, MartinRJ. The only thing that give me pause for thought is - if the crash is coming from an uncaught exception, the 'right' thing to do seems to be to catch the exception and show the notification you've created then, aborting the login. Any clear reason why this isn't the approach? Does pre-validation give a better user experience? Cheers. - Tofu Buzzard On March 24, 2012, 5:33 a.m., MartinRJ Fayray wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/563/ > ----------------------------------------------------------- > > (Updated March 24, 2012, 5:33 a.m.) > > > Review request for Viewer. > > > Description > ------- > > FIX FOR STORM-1818 (https://jira.secondlife.com/browse/storm-1818) "Abnormal > program termination when I enter an URL to the grid selection combobox > (login-screen) and press enter." > > Repository with fix: https://bitbucket.org/MartinRJ/storm-1818/ > > About: > When entering a malformed grid dns address, the viewer needs to catch the > malformed address. Currently it throws an error in a subroutine of the > grid-address-handling (llviewernetwork.cpp, function 'addGrid') and crashes > without warning due to a thrown error ("throw LLInvalidGridName(grid);"). > > This fix adds code to: > notifications.xml (a warning message text/notification: "IllegalGridName"), > llviewernetwork.h (a function which checks whether a given grid exists, by > name (string): bool getGridExists), > llpanellogin.cpp (an include for llviewernetwork.h, and a check against an > invalid grid dns address in function onSelectServer). > > Todo: Maybe edit the notification message, and update the language files. > > > This addresses bug STORM-1818. > http://jira.secondlife.com/browse/STORM-1818 > > > Diffs > ----- > > indra/newview/llpanellogin.cpp acfb0781d850 > indra/newview/llviewernetwork.h acfb0781d850 > indra/newview/skins/default/xui/en/notifications.xml acfb0781d850 > > Diff: http://codereview.secondlife.com/r/563/diff/diff > > > Testing > ------- > > Test plan: Insert a malformed grid dns address (e.g. > http://grid.francogrid.org:8002 which works with some TPVs) into the grid > selection combo on the login screen. > Expected behaviour: a popup shows up, informing about the malformed address, > and the grid selection combo swaps back to the default grid (Agni). > > > Thanks, > > MartinRJ Fayray > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
