Re: cvs commit: openssl/crypto/bn bn_lib.c bn_shift.c bntest.cexpspeed.c

[Richard Levitte - VMS Whacker]

From: [EMAIL PROTECTED]

bodo>   Add comment in bn_lib.c (why zero data between top and max?)

bodo>           /* Now need to zero any data between b->top and b->max */
bodo>   +       /* XXX Why? */

Because most functions that do expansions also use the expanded array
in operations like bn_add_words() that expects the two input arrays to
be of the same size.  I know that some functions, like BN_mul(), do a
(needless) zeroing of their own, but there are others who simply trust
BN_wexpand() and others to do the right thing for them.  Of those
words didn't get zeroed, you'd get very surprising (and may I say it:
unsafe!) result.

-- 
Richard Levitte   \ Spannv�gen 38, II \ [EMAIL PROTECTED]
Chairman@Stacken   \ S-168 35  BROMMA  \ T: +46-8-26 52 47
Redakteur@Stacken   \      SWEDEN       \ or +46-709-50 36 10
Procurator Odiosus Ex Infernis                -- [EMAIL PROTECTED]
Member of the OpenSSL development team: http://www.openssl.org/
Software Engineer, Celo Communications: http://www.celocom.com/

Unsolicited commercial email is subject to an archival fee of $400.
See <http://www.stacken.kth.se/~levitte/mail/> for more info.
______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       [EMAIL PROTECTED]
Automated List Manager                           [EMAIL PROTECTED]