[[EMAIL PROTECTED] - Thu Jun 27 11:32:12 2002]:

> x509.h : This is the change I'm genuinely unsure about.  x509.h
> includes
> asn1.h, but both x509/x_all.c and x509v3/v3_bitst.c reference (via
> macros)
> struct ASN1_ITEM_st, which is defined not in asn1.h but in asn1t.h.
> Since both files include x509.h, which includes asn1.h, and since
> asn1t.h
> includes asn1.h, I've changed x509.h to include asn1t.h instead of
> asn1.h.
> Someone who knows the code better may be able to come up with a 
better
> solution.

I'm not sure why this should be a problem.  Have you gotten some 
kind off errors or warnings because if the inclusion of asn1.h 
instead of asn1t.h?  You see, asn1.h does define ASN1_ITEM and 
declares the extense of struct ASN1_ITEM_st.  Unless the .c files 
you mention are actually poking in that structure or need to know 
it's size, there's no reason to define the structure.  I haven't had 
any problems in my builds (on Linux and Solaris)...

> do_nasm.bat : Change all xx-win32.asm files to xx_win32.asm.  If 
the
> filenames have hyphens in them, this gets interpreted by the dumb
> borland
> linker as an option later on in the build.  Since according to the
> commit
> on x86nasm.pl, nasm never worked anyway under Windows, this change
> shouldn't bother anyone.  Also, generate a bcb.mak using mk1mf.pl 
and
> 'nasm'.

Eeeeeep!  Not good to do that without making the same change to 
VC-32.pl and so on as you did to BC-32.pl...  I'll see if I've the 
energy to make an effort there...

Otherwise, I see no reason why this change should disturb anything...

-- 
Richard Levitte
______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       [EMAIL PROTECTED]
Automated List Manager                           [EMAIL PROTECTED]

Reply via email to