On Tue, 31 May 2005, Doug Kaufman wrote: > On Tue, 31 May 2005, Andy Polyakov wrote: > > > The latter proposed change, quoting DEVRANDOM, shall have adverse effect > > on other platforms. Can you elaborate on the error during compilation > > instead? As for mtu and sock_type. Is it possible to resolve it by > > The quoting of DEVRANDOM was incorporated into beta3, so the problems on > other platforms should be reported soon. I just reverted the quoting and
You are quite correct, in that quoting DEVRANDOM was the wrong thing to do. It put the string "DEVRANDOM" into the library instead of the value of DEVRANDOM. I am sorry that I didn't realize exactly what the quoting was doing before I submitted the patch. I think I have finally found the proper fix, however. This patch is against openssl 0.9.8 beta-3. It removes the quoting of DEVRANDOM and quotes "$(BUILDENV)" in crypto/Makefile. This preserves the appropriate escaping of special characters. With this patch on DJGPP, openssl 0.9.8-beta3 goes through Configure, make depend, make, make test, and make install without problems (although you still have to remove the two instances of "set -e" in Makefile if you want all the man pages to be installed). I hope that this doesn't introduce any new problems. I am sending a copy of the patch to the usual US government addresses. After the build, openssl reports itself as: OpenSSL 0.9.8-beta3 31 May 2005 built on: Wed Jun 1 12:10:10 PST 2005 platform: DJGPP options: bn(64,32) md2(int) rc4(idx,int) des(ptr,risc1,16,long) blowfish(idx) compiler: gcc -I/dev/env/WATT_ROOT/inc -DTERMIOS -DL_ENDIAN -fomit-frame-pointer -O2 -Wall -DDEVRANDOM="/dev/urandom\x24" -DOPENSSL_BN_ASM_PART_WORDS -DSHA1_ASM -DMD5_ASM -DRMD160_ASM -DAES_ASM OPENSSLDIR: "/dev/env/DJDIR/ssl" The patch: --- crypto/Makefile.ori 2005-05-18 17:48:46.000000000 -0800 +++ crypto/Makefile 2005-06-01 11:38:04.000000000 -0800 @@ -88,7 +88,7 @@ @for i in $(SDIRS) ;\ do \ (cd $$i && echo "making all in crypto/$$i..." && \ - $(MAKE) $(BUILDENV) INCLUDES='${INCLUDES}' all ) || exit 1; \ + $(MAKE) "$(BUILDENV)" INCLUDES='${INCLUDES}' all ) || exit 1; \ done; files: --- crypto/rand/rand_unix.c.ori 2005-05-30 14:37:40.000000000 -0800 +++ crypto/rand/rand_unix.c 2005-06-01 11:42:44.000000000 -0800 @@ -153,7 +153,7 @@ int n = 0; #endif #ifdef DEVRANDOM - static const char *randomfiles[] = { "DEVRANDOM" }; + static const char *randomfiles[] = { DEVRANDOM }; struct stat randomstats[sizeof(randomfiles)/sizeof(randomfiles[0])]; int fd,i; #endif Doug -- Doug Kaufman Internet: [EMAIL PROTECTED] ______________________________________________________________________ OpenSSL Project http://www.openssl.org Development Mailing List openssl-dev@openssl.org Automated List Manager [EMAIL PROTECTED]