Hi,
ext Roumen Petrov wrote:
Some notes about patch:
First, thank you for having a look at it.
- INSTALL.WCE
"perl by MSYS" what is this ?
If this is perl build from mingw32 project ? I can't found perl issue
in mingw32 bug tracker. Since the issue is not confirmed you can't write
that a package don't work.
Sorry, I meant the one from the mingw32 project. I use msysgit in my
environment, thus I mixed up with the names. In any case, if I use that
perl version, then nmake is not capable of parsing the generated
makefiles. I can send a diff of both versions to this thread or create
another request, if you prefer that.
- apps/ocsp.c
why extra include of <winsock2.h>? this mean that e_os.h patch is
incomplete.
I was tempted to add the include in e_os.h, but as this is the only file
requiring this header I felt it to be much cleaner. If the general
consensus is that e_os should be responsible for header inclusion
ignoring that other files will use it for no purpose, I can change the
patch accordingly.
- ms/do_ms.bat
please keep changes minimal
There seemed to be a line-ending mixup or sth. It basically just adds
"enable-experimental-jpake" to the WinCE makefile generator.
- util/pl/VC-32.pl
please don't remove flags that affect warnings. WX->Wall ?
As stated in the mail, I needed to disable WX to have at least a
successful compilation. WX treats warnings as errors and thus it will
fail on two instances, where my knowledge about OpenSSL insides is
limited. As already mentioned, I can send both compile warnings(errors)
to this list and somebody can have a look at them.
why is linked with crypt32 ?
The additional dependency results from using Cert* functions inside of
engines/e_capi.c.
Best Regards,
Maurice Kalinowski
--
Maurice Kalinowski - maurice.kalinowski (AT) nokia.com
Software Engineer - Nokia, Qt Software
Rudower Chaussee 13, 12489 Berlin, Germany
______________________________________________________________________
OpenSSL Project http://www.openssl.org
Development Mailing List [email protected]
Automated List Manager [EMAIL PROTECTED]
