Hi All, Just reviewing this code and I have a couple of questions:
[cryptodev_do_sign, line 863] The 'dgst' parameter is not subjected to a byte swap operation (as the Bignum params are). Is that what was intended? What is the rule for passing parameters to OCF? It is OK if the sign and verify are done in the Driver, but if one or the other is done in software, verification would fail. [cryptodev_do_verify, line 910] 'dsaret' return parameter is set equal to 'kop.crk_status'. OCF Success parameter is 0. OpenSSL success parameter is 1. I think this line needs to be changed to something like: if(0 == kop.crk_status) dsaret = 1; Regards, Brendan ------------------------------------------------ Brendan Kennedy Intel Shannon Ltd., Brookvale Plaza, Shannon, Co. Clare, Ireland. Tel: +353 61 477 704 Email: [EMAIL PROTECTED]<mailto:[EMAIL PROTECTED]> ------------------------------------------------ --------------------------------------------------------------------- Intel Shannon Limited Registered in Ireland Registered Office: One Spencer Dock, North Wall Quay, Dublin 1 Registered Number: 308263 Business address: Dromore House, East Park, Shannon, Co. Clare This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
