> [EMAIL PROTECTED] - Thu Nov 27 07:45:29 2008]: > > This patch is the first portion of SRP (RFC 5054) support in OpenSSL. > > The original work to add SRP to OpenSSL was done by the EdelKey project > (http://www.edelweb.fr/EdelKey/). I am updating these patches for the > latest > development version of OpenSSL (0.9.9) and submitting them for > integration. > > This first patch only includes support for the 'crypto/srp' directory > and the > 'openssl/srp' command, as well as the 'no-srp' conditional compilation > directive in 'configure'. This does NOT yet include support for TLS/SRP > > ciphersuites, which will be added in an upcoming patch. > > This patch applies cleanly against the 20081125 and 20081126 dev > snapshots. > >
A few initial comments. The copyright notice in srp.c gives the impression Eric Young wrote that file... I'm assuming he didn't and it is a combination of work from other files in apps he did write. The indentation in srp.c (perhaps as a result) is very inconsistent. Indentation in other files doesn't follow the "standard" of the rest of OpenSSL (well most of it). In a couple of files the low level SHA1 digest API is used directly. That should be avoided because it precludes use of ENGINEs in future. Use EVP instead. ______________________________________________________________________ OpenSSL Project http://www.openssl.org Development Mailing List [email protected] Automated List Manager [EMAIL PROTECTED]
