On Fri, 26 Nov 2010, Zouzou via RT wrote:

> i am reporting a bug with regards to a missing flag in MinGW targets. 
> the bug is present in both 0.9 and 1.0 branches; it is (in our case) 
> only leading to crashes in 1.0.
> 
> the missing flag is: OPENSSL_SYSNAME_WIN32
> it is always defined for MSVC targets, but MinGW ones are forgetting to 
> add it. this leads to the following situation:
> ... 
> adding " -DOPENSSL_SYSNAME_WIN32" to Configure:508 (mingw target) and 
> Configure:516 (mingw64 target) solves these problems.
> 
> and while these flags are being fiddled with, i also recommend the 
> "-mno-cygwin" flags be removed since they have been deprecated for a 
> while now (for so long that they now provoke a compiler error).

The last proposed change would break the build for mingw done under
cygwin, since the -mno-cygwin flag is critical there. The only place
I see where OPENSSL_SYSNAME_WIN32 is used is to define MS_STATIC.
MS_STATIC is used in 20 places in the code. Are you proposing that
MS_STATIC be changed in all 20 places for mingw, or just for the
instance in crypto/evp? Should the "static" flag be removed in all?

The configure settings for mingw were clearly written with compiling
from cygwin in mind. Perhaps the cygwin build and the MSYS builds are
now different enough, that what you may really be asking for is a new
target for mingw built under MSYS. You could give it a name such as
"mingw-msys" or rename the old configuration to "mingw-cygwin". That
way, each could be tweaked separately.

Doug
-- 
Doug Kaufman
Internet: [email protected]




______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       [email protected]
Automated List Manager                           [email protected]

Reply via email to