On 12/20/2013 03:30 PM, Matt Caswell wrote:
> I had this problem with my ocb patch recently. For future reference, I
> solved it by creating a temporary branch and using git merge --squash.
> So if your commits are on "my-branch", and you want to create a patch
> against master:

fwiw, i think squashing all the patches would make this change
significantly more difficult to review.

I deliberately broke the changes into logical units that are reviewable
and understandable; merging all 10 of them down to one squashed patch
would render that one patch much more difficult for me to make sense of
(if i was on the reviewing side of the patch submission process), even
though the effect on the code would be the same.

Regards,

        --dkg

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to