On 05/12/2014 03:18 PM, Daniel Kahn Gillmor via RT wrote:
> I'm happy that the PFS key exchange normalization changesets haveb been
> merged into master.
> 
> I've submitted https://github.com/openssl/openssl/pull/106 for the 1.0.2
> stable branch to add similar aliasing for the library input strings.  This
> provides forward compatibility with any documentation produced using the
> standardized labels (DHE and ECDHE).
> 
> Since this is on a stable branch, it doesn't change the output.
> 
> I considered replacing all the internal #defines to use the standardized
> labels by default within the code as well (e.g. using SSL_kDHE instead
> of SSL_kEDH everywhere internally) -- the aliases exist so the two terms
> are equivalent, and both will remain #define'd.  But i decided to leave
> the internal code as untouched as possible for the stable branch.  I'm
> happy to go through and clean up the internal uses as well if folks
> think that'd be a good idea for 1.0.2.
> 
> If this patch is considered acceptable for 1.0.2, i can go back and
> create similar pull requests for the other stable branches.

Any thoughts on this?  I'd be happy to see this fixed in 1.0.1 and 1.0.0
and 0.9.8 as well, so that we can use the standard terminology on every
stable branch.

        --dkg

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to