On Thu, Aug 15, 2013 at 7:57 AM, Christopher Yeoh <cbky...@gmail.com> wrote:
> On Thu, Aug 15, 2013 at 9:54 PM, Daniel P. Berrange > <berra...@redhat.com>wrote:Commit message quality has improved somewhat since > I first wrote & > published > > that page, but there's definitely still scope to improve things further. >> What >> it really needs is for more reviewers to push back against badly written >> commit messages, to nudge authors into the habit of being more verbose in >> their commits. >> >> > Agreed. There is often "what" and sometimes "why", but not very often > "how" in commit messages. > ++ Beyond the one line summary (which *should* describe "what" changed), describing "what" changed in the commit message is entirely redundant with the commit itself. > > Chris > > _______________________________________________ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > -- -Dolph
_______________________________________________ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
