Hi, I'm ok with both accepting this patch and reverting the commit, which introduced the regression, but it would be really nice to have these DB optimizations in Nova.
As for your concern of accepting such optimizations. I don't think, it's a problem of such patches themselves, but rather with the lack of comprehensive tests of complex OpenStack installations in our CI (at the same time I personally believe our CI is the best thing ever happened to OpenStack :), CI team you really rock!). Anyway, TripleO-CI found this regression. Maybe we should consider adding its job to Nova check/gate pipelines? Thanks, Roman On Mon, Sep 9, 2013 at 1:59 PM, Nikola Đipanov <ndipa...@redhat.com> wrote: > On 09/09/13 11:25, Roman Podolyaka wrote: > > Hi, > > > > There is a patch on review (https://review.openstack.org/#/c/45422/) > > fixing https://bugs.launchpad.net/tripleo/+bug/1221620 which has > > importance 'Critical' in Nova and TripleO (long story short: currently > > Nova Baremetal deployments with more than one baremetal node won't work). > > > > It would be really nice to have this patch reviewed by core developers, > > so we can fix the bug ASAP. > > > > Hey - thanks for responding quickly - I commented on the patch and tbh I > am starting to be -1 on this due to issues mentioned on the review. > > I will accept that my take on this is too conservative :) and remove a > -1 if needed to get this in, but at this point, I have some doubts > weather this is the right approach. > > Cheers, > > N. > > > > Thanks, > > Roman > > > > > > _______________________________________________ > > OpenStack-dev mailing list > > OpenStack-dev@lists.openstack.org > > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > > > > _______________________________________________ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >
_______________________________________________ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev