On Fri, Sep 22, 2017 at 10:26:09AM +0800, Zhipeng Huang wrote: > Let's not forget the epic fail earlier on the "contribution.rst fix" that > almost melt down the community CI system. > > For any companies that are doing what Matt mentioned, please be aware that > the dev community of the country you belong to is getting hurt by your > stupid activity. > > Stop patch trolling and doing something meaningful. > Sorry, but I found this comment over the line. Just because you disagree with the $topic at hand, doesn't mean you should default to calling it 'stupid'. Give somebody the benefit of not knowing any better.
This is not a good example of encouraging anybody to contribute to the project. -Paul > On Fri, Sep 22, 2017 at 10:21 AM, Matt Riedemann <mriede...@gmail.com> > wrote: > > > I just wanted to highlight to people that there seems to be a series of > > garbage patches in various projects [1] which are basically doing things > > like fixing a single typo in a code comment, or very narrowly changing http > > to https in links within docs. > > > > Also +1ing ones own changes. > > > > I've been trying to snuff these out in nova, but I see it's basically a > > pattern widespread across several projects. > > > > This is the boilerplate comment I give with my -1, feel free to employ it > > yourself. > > > > "Sorry but this isn't really a useful change. Fixing typos in code > > comments when the context is still clear doesn't really help us, and mostly > > seems like looking for padding stats on stackalytics. It's also a drain on > > our CI environment. > > > > If you fixed all of the typos in a single module, or in user-facing > > documentation, or error messages, or something in the logs, or something > > that actually doesn't make sense in code comments, then maybe, but this > > isn't one of those things." > > > > I'm not trying to be a jerk here, but this is annoying to the point I felt > > the need to say something publicly. > > > > [1] https://review.openstack.org/#/q/author:%255E.*inspur.* > > > > -- > > > > Thanks, > > > > Matt > > > > __________________________________________________________________________ > > OpenStack Development Mailing List (not for usage questions) > > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > > > > > -- > Zhipeng (Howard) Huang > > Standard Engineer > IT Standard & Patent/IT Product Line > Huawei Technologies Co,. Ltd > Email: huangzhip...@huawei.com > Office: Huawei Industrial Base, Longgang, Shenzhen > > (Previous) > Research Assistant > Mobile Ad-Hoc Network Lab, Calit2 > University of California, Irvine > Email: zhipe...@uci.edu > Office: Calit2 Building Room 2402 > > OpenStack, OPNFV, OpenDaylight, OpenCompute Aficionado > __________________________________________________________________________ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev