Sean Dague said on Thu, Mar 06, 2014 at 01:05:15PM -0500: > The results of this have been that design review today is typically not > happening on Blueprint approval, but is instead happening once the code > shows up in the code review. So -1s and -2s on code review are a mix of > design and code review. A big part of which is that design was never in > any way sufficiently reviewed before the code started.
+1 to the idea. Would it be useful to require a single bp for changes to contended files, EG the ComputeNode class definition? If the fields to be added had been agreed up-front, some considerable rebasing could have been avoided. Alexis -- Nova Engineer, HP Cloud. AKA lealexis, lxsli. _______________________________________________ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
