On Fri, Dec 5, 2014 at 4:39 PM, Russell Bryant <[email protected]> wrote:
> On 12/05/2014 08:41 AM, Daniel P. Berrange wrote: > > On Fri, Dec 05, 2014 at 11:05:28AM +1100, Michael Still wrote: > >> One of the things that happens over time is that some of our core > >> reviewers move on to other projects. This is a normal and healthy > >> thing, especially as nova continues to spin out projects into other > >> parts of OpenStack. > >> > >> However, it is important that our core reviewers be active, as it > >> keeps them up to date with the current ways we approach development in > >> Nova. I am therefore removing some no longer sufficiently active cores > >> from the nova-core group. > >> > >> I’d like to thank the following people for their contributions over the > years: > >> > >> * cbehrens: Chris Behrens > >> * vishvananda: Vishvananda Ishaya > >> * dan-prince: Dan Prince > >> * belliott: Brian Elliott > >> * p-draigbrady: Padraig Brady > >> > >> I’d love to see any of these cores return if they find their available > >> time for code reviews increases. > > > > What stats did you use to decide whether to cull these reviewers ? > Looking > > at the stats over a 6 month period, I think Padraig Brady is still having > > a significant positive impact on Nova - on a par with both cerberus and > > alaski who you've not proposing for cut. I think we should keep Padraig > > on the team, but probably suggest cutting Markmc instead > > > > http://russellbryant.net/openstack-stats/nova-reviewers-180.txt > > > > > +-----------------------------+----------------------------------------+----------------+ > > | Reviewer | Reviews -2 -1 +1 +2 +A +/- % | > Disagreements* | > > > +-----------------------------+----------------------------------------+----------------+ > > | berrange ** | 1766 26 435 12 1293 357 73.9% > | 157 ( 8.9%) | > > | jaypipes ** | 1359 11 378 436 534 133 71.4% > | 109 ( 8.0%) | > > | jogo ** | 1053 131 326 7 589 353 56.6% > | 47 ( 4.5%) | > > | danms ** | 921 67 381 23 450 167 51.4% > | 32 ( 3.5%) | > > | oomichi ** | 889 4 306 55 524 182 65.1% > | 40 ( 4.5%) | > > | johngarbutt ** | 808 319 227 10 252 145 32.4% > | 37 ( 4.6%) | > > | mriedem ** | 642 27 279 25 311 136 52.3% > | 17 ( 2.6%) | > > | klmitch ** | 606 1 90 2 513 70 85.0% > | 67 ( 11.1%) | > > | ndipanov ** | 588 19 179 10 380 113 66.3% > | 62 ( 10.5%) | > > | mikalstill ** | 564 31 34 3 496 207 88.5% > | 20 ( 3.5%) | > > | cyeoh-0 ** | 546 12 207 30 297 103 59.9% > | 35 ( 6.4%) | > > | sdague ** | 511 23 89 6 393 229 78.1% > | 25 ( 4.9%) | > > | russellb ** | 465 6 83 0 376 158 80.9% > | 23 ( 4.9%) | > > | alaski ** | 415 1 65 21 328 149 84.1% > | 24 ( 5.8%) | > > | cerberus ** | 405 6 25 48 326 102 92.3% > | 33 ( 8.1%) | > > | p-draigbrady ** | 376 2 40 9 325 64 88.8% > | 49 ( 13.0%) | > > | markmc ** | 243 2 54 3 184 69 77.0% > | 14 ( 5.8%) | > > | belliott ** | 231 1 68 5 157 35 70.1% > | 19 ( 8.2%) | > > | dan-prince ** | 178 2 48 9 119 29 71.9% > | 11 ( 6.2%) | > > | cbehrens ** | 132 2 49 2 79 19 61.4% > | 6 ( 4.5%) | > > | vishvananda ** | 54 0 5 3 46 15 90.7% > | 5 ( 9.3%) | > > > > Yeah, I was pretty surprised to see pbrady on this list, as well. The > above was 6 months, but even if you drop it to the most recent 3 months, > he's still active ... > As you are more then aware of, our policy for removing people from core is to leave that up the the PTL (I believe you wrote that) [0]. And I don't think numbers alone are a good metric for sorting out who to remove. That being said no matter what happens, with our fast track policy, if pbrady is dropped it shouldn't be hard to re-add him. [0] https://wiki.openstack.org/wiki/Nova/CoreTeam#Adding_or_Removing_Members <https://wiki.openstack.org/wiki/Nova/CoreTeam#Adding_or_Removing_Members> > > > > Reviews for the last 90 days in nova > > ** -- nova-core team member > > > +-----------------------------+---------------------------------------+----------------+ > > | Reviewer | Reviews -2 -1 +1 +2 +A +/- % | > Disagreements* | > > > +-----------------------------+---------------------------------------+----------------+ > > | berrange ** | 708 13 145 1 549 200 77.7% | > 47 ( 6.6%) | > > | jogo ** | 594 40 218 4 332 174 56.6% | > 27 ( 4.5%) | > > | jaypipes ** | 509 10 180 17 302 77 62.7% | > 33 ( 6.5%) | > > | oomichi ** | 392 1 136 10 245 74 65.1% | > 6 ( 1.5%) | > > | danms ** | 386 38 155 16 177 77 50.0% | > 16 ( 4.1%) | > > | ndipanov ** | 345 17 118 7 203 61 60.9% | > 32 ( 9.3%) | > > | mriedem ** | 304 12 136 12 144 56 51.3% | > 12 ( 3.9%) | > > | klmitch ** | 281 1 42 0 238 19 84.7% | > 32 ( 11.4%) | > > | cyeoh-0 ** | 270 11 112 12 135 47 54.4% | > 13 ( 4.8%) | > > | mikalstill ** | 261 7 8 3 243 106 94.3% | > 7 ( 2.7%) | > > | sdague ** | 246 19 41 2 184 104 75.6% | > 10 ( 4.1%) | > > | johngarbutt ** | 216 25 92 7 92 43 45.8% | > 8 ( 3.7%) | > > | alaski ** | 161 0 17 8 136 81 89.4% | > 6 ( 3.7%) | > > | cerberus ** | 157 0 9 41 107 41 94.3% | > 8 ( 5.1%) | > > | p-draigbrady ** | 143 0 21 3 119 26 85.3% | > 9 ( 6.3%) | > > | russellb ** | 123 1 15 0 107 41 87.0% | > 8 ( 6.5%) | > > | belliott ** | 66 0 17 2 47 24 74.2% | > 5 ( 7.6%) | > > | cbehrens ** | 20 0 4 0 16 2 80.0% | > 1 ( 5.0%) | > > | vishvananda ** | 18 0 3 0 15 6 83.3% | > 2 ( 11.1%) | > > | dan-prince ** | 16 0 1 0 15 6 93.8% | > 5 ( 31.2%) | > > > -- > Russell Bryant > > _______________________________________________ > OpenStack-dev mailing list > [email protected] > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >
_______________________________________________ OpenStack-dev mailing list [email protected] http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
